Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove strange user selection rule #49

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

eMerzh
Copy link
Collaborator

@eMerzh eMerzh commented Feb 11, 2024

not sure why those where here 🤔

but i find it strangely annoying ....

@h16nning h16nning merged commit 9742874 into h16nning:main Feb 11, 2024
2 checks passed
@h16nning
Copy link
Owner

Sure, I implemented those out of personal preference haha. Seems like it is not really good ux practice though, so we can remove them.

@eMerzh
Copy link
Collaborator Author

eMerzh commented Feb 11, 2024

oh 🤔 interesting.... be interested to hear why you prefer that? like maybe there is some ground that need to be fixed 🤔

@h16nning
Copy link
Owner

hmm...
I would say it feels more like an "app" and less like a website if you can't select everything, maybe that is a little silly haha. Especially with static text like the "Welcome back..." or section headers etc. I don't understand what the point in selecting those is...

However, generally disabling user select on all Title components is probably not so good. Just noticed this also disabled text selection in NotebookView or LearnView which was unintentional. Were those situations annoying you?

I think I implemented some more specific user-select nones in other places like "It's looking empty here" in DeckView. Would you prefer to keep those?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants